Jonathan Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38594 )
Change subject: arch/x86: add acpigen resource support
......................................................................
Patch Set 4:
(3 comments)
https://review.coreboot.org/c/coreboot/+/38594/3//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/38594/3//COMMIT_MSG@9
PS3, Line 9: Added
Add
Done
https://review.coreboot.org/c/coreboot/+/38594/3/src/arch/x86/acpigen.c
File src/arch/x86/acpigen.c:
https://review.coreboot.org/c/coreboot/+/38594/3/src/arch/x86/acpigen.c@1767
PS3, Line 1767: /* Byte 1+2: length (0x000d) */
Indent correctly.
Done
https://review.coreboot.org/c/coreboot/+/38594/3/src/arch/x86/acpigen.c@1819
PS3, Line 1819: /* Byte 1+2: length (0x002b) */
Indent.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38594
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I707f8a443090b6f30e2940b721f9555ccdf49d32
Gerrit-Change-Number: 38594
Gerrit-PatchSet: 4
Gerrit-Owner: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Anjaneya "Reddy" Chagam
anjaneya.chagam@intel.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 29 Jan 2020 18:34:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment