Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45878 )
Change subject: tigerlake mainboards: switch to devtree aliases for PMC MUX connectors
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45878/3/src/mainboard/google/voltee...
File src/mainboard/google/volteer/mainboard.c:
https://review.coreboot.org/c/coreboot/+/45878/3/src/mainboard/google/voltee...
PS3, Line 20: variant_init
do you need this indirection? wouldn't the search for port1 weed out the variants that don' t need i […]
Ah, I hadn't looked through all of the variants to see if this would break any of the others. Looks like not, I'll rearrange.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45878
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib51764da5b3c029f9ac7ac60199a0aedfc7f29b1
Gerrit-Change-Number: 45878
Gerrit-PatchSet: 4
Gerrit-Owner: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 20 Oct 2020 22:22:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Duncan Laurie
dlaurie@chromium.org
Gerrit-MessageType: comment