[coreboot-gerrit] Change in coreboot[master]: soc/amd/picasso: use FADT devicetree configuration options

[Felix Held (Code Review)]

Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43418 )

Change subject: soc/amd/picasso: use FADT devicetree configuration options
......................................................................

Patch Set 4:

(1 comment)

https://review.coreboot.org/c/coreboot/+/43418/1/src/soc/amd/picasso/acpi.c 
File src/soc/amd/picasso/acpi.c:

https://review.coreboot.org/c/coreboot/+/43418/1/src/soc/amd/picasso/acpi.c@... 
PS1, Line 132: 		fadt->flags = cfg->fadt_flags;
> I don't think repeating all the FADT flags on each devicetree is a good idea. […]

it might be a good idea to set all options that are mandatory here and only bitwise or that with the additional settings from the devicetree