Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35321 )
Change subject: soc/fsp_broadwell_de: Add devhide functionality ......................................................................
Patch Set 8:
(3 comments)
https://review.coreboot.org/c/coreboot/+/35321/8/src/soc/intel/fsp_broadwell... File src/soc/intel/fsp_broadwell_de/include/soc/pci_devs.h:
https://review.coreboot.org/c/coreboot/+/35321/8/src/soc/intel/fsp_broadwell... PS8, Line 54: Possibly change all the spaces to tabs in a follow on commit? Up to you.
https://review.coreboot.org/c/coreboot/+/35321/8/src/soc/intel/fsp_broadwell... PS8, Line 113: Coming of from Reword this?
https://review.coreboot.org/c/coreboot/+/35321/8/src/soc/intel/fsp_broadwell... File src/soc/intel/fsp_broadwell_de/include/soc/ubox.h:
https://review.coreboot.org/c/coreboot/+/35321/8/src/soc/intel/fsp_broadwell... PS8, Line 42: : static inline void iio_hide(const uint8_t devno, const uint8_t funcno) Why make this an inline function in a .h file instead of just in the case statement directly? Even just put it in the .c file and let the compiler decide to inline it if it wants to.