Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32027 )
Change subject: Make common macros double-evaluation safe
......................................................................
Patch Set 11:
I just got a report that this breaks the build on ubuntu 14.04. We might want to test it some more to make sure it doesn't break any other build environments.
Do you have the error message? I assume it's a name collision with one of the new macros (maybe __CMP). It's impossible to predict all the possible conflicts with all possible environments this may have, but if we know which ones to check for, it should be easy to fix.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32027
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iea35156c9aa9f6f2c7b8f00991418b746f44315d
Gerrit-Change-Number: 32027
Gerrit-PatchSet: 11
Gerrit-Owner: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 15 Apr 2019 20:29:23 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment