[coreboot-gerrit] Change in ...coreboot[master]: [WIP]device/pci_rom: Add ATRM method

[Patrick Rudolph (Code Review)]

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31502 )

Change subject: [WIP]device/pci_rom: Add ATRM method
......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/31502/1/src/device/pci_rom.c 
File src/device/pci_rom.c:

https://review.coreboot.org/#/c/31502/1/src/device/pci_rom.c@326 
PS1, Line 326: 	acpigen_write_rom(cbrom, cbrom_length);
> Do we still need _ROM in AMD case? If not, how about passing the method […]

At least the AMD driver in linux doesn't need _ROM.
But _ROM is defined in ACPI spec, and it costs us nothing.
It looks like the kernel uses the _ROM method to identify ACPI compatible "video devices".