Scott Chao has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/79244?usp=email )
Change subject: mb/google/nissa: update GPP_F17 to edge trigger ......................................................................
mb/google/nissa: update GPP_F17 to edge trigger
Currently, we set GPP_F17 to level triggered, it will cause AP keep sending GET_NEXT_EVENT to EC during resume from suspend by connect AC. So we change GPP_F17 to edge triggered to avoid this condition.
BUG=b:308716748 TEST=Test on joxer with 6 units, 0 out of 60 times.
Signed-off-by: Scott Chao scott_chao@wistron.corp-partner.google.com Change-Id: I3ceb1dfce46376a6a9a8c6cb6d691d818a0a42ff --- M src/mainboard/google/brya/variants/baseboard/nissa/gpio.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/44/79244/1
diff --git a/src/mainboard/google/brya/variants/baseboard/nissa/gpio.c b/src/mainboard/google/brya/variants/baseboard/nissa/gpio.c index 781f00a..5d83e7a 100644 --- a/src/mainboard/google/brya/variants/baseboard/nissa/gpio.c +++ b/src/mainboard/google/brya/variants/baseboard/nissa/gpio.c @@ -242,7 +242,7 @@ /* F16 : NC */ PAD_NC_LOCK(GPP_F16, NONE, LOCK_CONFIG), /* F17 : THC1_SPI2_RST# ==> EC_SOC_WAKE_ODL */ - PAD_CFG_GPI_IRQ_WAKE_LOCK(GPP_F17, NONE, LEVEL, INVERT, LOCK_CONFIG), + PAD_CFG_GPI_IRQ_WAKE_LOCK(GPP_F17, NONE, EDGE_SINGLE, INVERT, LOCK_CONFIG), /* F18 : THC1_SPI2_INT# ==> EC_IN_RW_OD */ PAD_CFG_GPI_LOCK(GPP_F18, NONE, LOCK_CONFIG), /* F19 : Not available */