Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42064 )
Change subject: soc/amd/picasso: Allow modification of i2c base addresses in PSP
......................................................................
Patch Set 16: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/42064/16/src/soc/amd/picasso/i2c.c
File src/soc/amd/picasso/i2c.c:
https://review.coreboot.org/c/coreboot/+/42064/16/src/soc/amd/picasso/i2c.c@...
PS16, Line 63: uint32_t
Sorry, I didn't catch this earlier...
uintptr_t
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42064
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I45380e0c61e1bb7a94a96630e5867b7ffca0909c
Gerrit-Change-Number: 42064
Gerrit-PatchSet: 16
Gerrit-Owner: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Eric Peers
epeers@google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 08 Jul 2020 19:10:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment