Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33616 )
Change subject: kodama: add a new configuration for Kodama.
......................................................................
Patch Set 5:
(1 comment)
I would split adding panel init into a separate change.
https://review.coreboot.org/c/coreboot/+/33616/5/src/mainboard/google/kukui/...
File src/mainboard/google/kukui/Kconfig:
https://review.coreboot.org/c/coreboot/+/33616/5/src/mainboard/google/kukui/...
PS5, Line 31: CHROMEOS_USE_EC_WATCHDOG_FLAG
jenkins complains about this
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33616
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I72e80e800ba041df1dda2b0f84470d1ef58bc946
Gerrit-Change-Number: 33616
Gerrit-PatchSet: 5
Gerrit-Owner: Peichao Li
peichao.wang@bitland.corp-partner.google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Peichao Li
peichao.wang@bitland.corp-partner.google.com
Gerrit-Reviewer: Zhuohao Lee
zhuohao@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Hao He
hao.he@bitland.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Xingyu Wu
wuxy@bitland.corp-partner.google.com
Gerrit-Comment-Date: Thu, 04 Jul 2019 12:50:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment