David Hendricks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38549 )
Change subject: mainboard/ocp: Add support for OCP platform TiogaPass
......................................................................
Patch Set 43: Code-Review-1
(3 comments)
Almost there - Looks like you may have forgotten to `git rm` the unused board ID files.
https://review.coreboot.org/c/coreboot/+/38549/43/src/mainboard/ocp/tiogapas...
File src/mainboard/ocp/tiogapass/boardid.c:
PS43:
remove this unused file
https://review.coreboot.org/c/coreboot/+/38549/43/src/mainboard/ocp/tiogapas...
File src/mainboard/ocp/tiogapass/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/38549/43/src/mainboard/ocp/tiogapas...
PS43, Line 29: # configure device interrupt routing
missed one
https://review.coreboot.org/c/coreboot/+/38549/43/src/mainboard/ocp/tiogapas...
File src/mainboard/ocp/tiogapass/tiogapass_boardid.h:
PS43:
remove this unused file
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38549
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I29868f03037d1887b90dfb19d15aee83c456edce
Gerrit-Change-Number: 38549
Gerrit-PatchSet: 43
Gerrit-Owner: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Anjaneya "Reddy" Chagam
anjaneya.chagam@intel.com
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Johnny Lin
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Andrey Petrov
anpetrov@fb.com
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 28 Feb 2020 23:44:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment