Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45610 )
Change subject: northbridge/intel/Kconfig: Move DEFAULT_MCHBAR to Kconfig ......................................................................
Patch Set 3: Code-Review+1
(2 comments)
https://review.coreboot.org/c/coreboot/+/45610/3/src/northbridge/intel/Kconf... File src/northbridge/intel/Kconfig:
https://review.coreboot.org/c/coreboot/+/45610/3/src/northbridge/intel/Kconf... PS3, Line 1: #SPDX-License-Identifier: GPL-2.0-or-later nit: space after the `#`
https://review.coreboot.org/c/coreboot/+/45610/3/src/northbridge/intel/Kconf... PS3, Line 3: DEFAULT_MCHBAR_ADDRESS `DEFAULT_MCHBAR` should be enough? Or is it giving you problems with the already-defined macros?
If so, then please mention so in the commit message.