Attention is currently required from: Ravi kumar. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49768 )
Change subject: sc7280: Add CPUCP firmware support ......................................................................
Patch Set 80:
(3 comments)
File src/soc/qualcomm/sc7280/cpucp_load_reset.c:
https://review.coreboot.org/c/coreboot/+/49768/comment/806876b4_4dab742a PS80, Line 11: #define EPSSFAST_EPSS_MUC_CLK_CTRL ((void *)0x18580000) Please define a struct overlay for this register block like in the other drivers.
https://review.coreboot.org/c/coreboot/+/49768/comment/399ed65f_b3dc46fe PS80, Line 19: write32(EPSSTOP_SECURE_ACCESS_OVERRIDE, val); Just use setbits32() to do this in one line.
https://review.coreboot.org/c/coreboot/+/49768/comment/35501d43_5d182405 PS80, Line 27: while ((read32(EPSSFAST_EPSS_MUC_CLK_CTRL) & 0x1) != 0x1) Please don't create endless loops without timeout (use wait_ms()).