Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36137 )
Change subject: soc/intel: skl,cnl,icl: consolidate ebda and memmap and move to common code ......................................................................
Patch Set 15:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36137/15/src/soc/intel/common/block... File src/soc/intel/common/block/include/intelblocks/ebda.h:
https://review.coreboot.org/c/coreboot/+/36137/15/src/soc/intel/common/block... PS15, Line 35: /* API for filling ebda with data */ Add a comment when it's called?