Attention is currently required from: Michał Żygowski, Igor Bagnucki, Michał Kopeć. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63463 )
Change subject: mainboard/msi/ms7d25: Add early support for MSI PRO Z690-A DDR4 WIFI ......................................................................
Patch Set 10:
(5 comments)
File src/mainboard/msi/ms7d25/dsdt.asl:
https://review.coreboot.org/c/coreboot/+/63463/comment/a59eb0a4_8374e2e3 PS10, Line 11: /* OEM revision */ It's not the OEM revision, this is just copy-pasta. Please drop the comment.
File src/mainboard/msi/ms7d25/romstage_fsp_params.c:
https://review.coreboot.org/c/coreboot/+/63463/comment/95a6cd02_2469dc85 PS10, Line 14: .resistor = 100, Seems OK.
https://review.coreboot.org/c/coreboot/+/63463/comment/24d95ef2_4184b2ae PS10, Line 17: 50, 20, 25, 25, 25 I think this should be `40, 30, 33, 33, 30`. If you have access to FSP sources, grep for `RcompTargetHDdr4`.
https://review.coreboot.org/c/coreboot/+/63463/comment/528eec53_3b190bae PS10, Line 20: .ect = true, /* Early Command Training */ I think this doesn't do anything on DDR4. At least, it doesn't on SKL/KBL/CFL.
https://review.coreboot.org/c/coreboot/+/63463/comment/7854c1c7_3df2488c PS10, Line 24: .LpDdrDqDqsReTraining = 1, This shouldn't be needed with DDR4