hsin-hsiung wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45399 )
Change subject: soc/mediatek/mt8192: add pmic MT6359P driver ......................................................................
Patch Set 20: Code-Review+1
(3 comments)
https://review.coreboot.org/c/coreboot/+/45399/1/src/soc/mediatek/mt8192/mt6... File src/soc/mediatek/mt8192/mt6359p.c:
https://review.coreboot.org/c/coreboot/+/45399/1/src/soc/mediatek/mt8192/mt6... PS1, Line 293: if (pmif_arb == NULL) : pmif_arb = get_pmif_controller(PMIF_SPI, 0);
Since pmif_arb should have been initialized in mt6359p_init(), there seems to be no need for this. […]
Done
https://review.coreboot.org/c/coreboot/+/45399/1/src/soc/mediatek/mt8192/mt6... PS1, Line 307: mt6359p_read_field
I think we can create generic functions for these, say […]
Done
https://review.coreboot.org/c/coreboot/+/45399/1/src/soc/mediatek/mt8192/mt6... PS1, Line 438: pmif_arb
What if this is still NULL (returned from get_pmif_controller())? Should we call die() within get_p […]
I will call die() in get_pmif_controller().