Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39299 )
Change subject: mb/asus/p8z77-v_lx2: Add new mainboard
......................................................................
Patch Set 3:
(3 comments)
https://review.coreboot.org/c/coreboot/+/39299/3//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/39299/3//COMMIT_MSG@7
PS3, Line 7: mb/asus/p8z77-v_lx2: Add new mainboard
Then Ivy Bridge.
*replaces CPU with an i7-2600* Um, now it's not Ivy Bridge!
You know what? I'll just use the socket name: LGA1155 😄
https://review.coreboot.org/c/coreboot/+/39299/3//COMMIT_MSG@27
PS3, Line 27:
Add tested payload and OS?
Oh, I thought I had that somewhere. In any case, it's SeaBIOS and Arch Linux
https://review.coreboot.org/c/coreboot/+/39299/3/src/mainboard/asus/p8z77-v_...
File src/mainboard/asus/p8z77-v_lx2/early_init.c:
https://review.coreboot.org/c/coreboot/+/39299/3/src/mainboard/asus/p8z77-v_...
PS3, Line 48: /* Select SIO pin states. */
It’s not needed in a comment, and for consistency (see below). […]
Ah, I see the inconsistency
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39299
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia5d9176b6f435977ecdd4fc82fc4bc0974d8d6a4
Gerrit-Change-Number: 39299
Gerrit-PatchSet: 3
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Evgeny Zinoviev
me@ch1p.io
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Jonathan Kollasch
jakllsch@kollasch.net
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 06 Mar 2020 15:33:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment