Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39514 )
Change subject: util/inteltool: gpio: initialize register size variables
......................................................................
Patch Set 6: Code-Review-1
(2 comments)
What does this fix? Isn't it just hiding potential bugs?
https://review.coreboot.org/c/coreboot/+/39514/6//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/39514/6//COMMIT_MSG@9
PS6, Line 9: Initialize register size variables to prevent segfaults.
If the program would read those variables on a broken path (only chance
for a segfault), the only thing we achieve with these initializations is
hiding bugs.
https://review.coreboot.org/c/coreboot/+/39514/6/util/inteltool/gpio_groups....
File util/inteltool/gpio_groups.c:
https://review.coreboot.org/c/coreboot/+/39514/6/util/inteltool/gpio_groups....
PS6, Line 185: communities = get_gpio_communities(sb, &community_count, &pad_stepping);
why initialize one arg but not the other?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39514
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I074a4de7f05a984e78bd7e02e0aa67e28c264340
Gerrit-Change-Number: 39514
Gerrit-PatchSet: 6
Gerrit-Owner: Michael Niewöhner
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Idwer Vollering
vidwer@gmail.com
Gerrit-Reviewer: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Reviewer: Mimoja
coreboot@mimoja.de
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sat, 21 Mar 2020 11:35:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment