Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47659 )
Change subject: soc/intel/common/fast_spi: Add custom boot media device ......................................................................
Patch Set 9:
(2 comments)
https://review.coreboot.org/c/coreboot/+/47659/9/src/soc/intel/common/block/... File src/soc/intel/common/block/fast_spi/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/47659/9/src/soc/intel/common/block/... PS9, Line 25: mmap_boot
I had named it mmap_boot. […]
It is still mmap_boot so it is technically correct.. You could just put a comment at the top. (it has the diagram but that still doesn't make it clear it only applies to the ext case)
https://review.coreboot.org/c/coreboot/+/47659/9/src/soc/intel/common/block/... File src/soc/intel/common/block/fast_spi/mmap_boot.c:
https://review.coreboot.org/c/coreboot/+/47659/9/src/soc/intel/common/block/... PS9, Line 103: CONFIG_EXT_BIOS_WIN_BASE
Yes, _Static_assert ensures that this gets checked at compile time.
oh right, of course..