23 Jun
2023
23 Jun
'23
6:33 a.m.
Attention is currently required from: Arthur Heymans, Lance Zhao, Tim Wawrzynczak.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76008?usp=email )
Change subject: acpi/acpi.c: Split of ACPI table generation into separate files ......................................................................
Patch Set 1:
(1 comment)
File src/acpi/acpi.c:
https://review.coreboot.org/c/coreboot/+/76008/comment/7f27453c_a995693b : PS1, Line 213: #if ENV_X86 Just wondering.. This pp if is missing in the new files. Is that intended? I would assume it should vanish with CB:76009. Just something I noticed. Please mark as resolved if you want to.
--
To view, visit https://review.coreboot.org/c/coreboot/+/76008?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5083b26c0d4cc6764b4e3cb0ff586797cae7e3af
Gerrit-Change-Number: 76008
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Felix Singer service+coreboot-gerrit@felixsinger.de
Gerrit-Reviewer: Lance Zhao lance.zhao@gmail.com
Gerrit-Reviewer: Tim Wawrzynczak inforichland@gmail.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Lance Zhao lance.zhao@gmail.com
Gerrit-Attention: Tim Wawrzynczak inforichland@gmail.com
Gerrit-Attention: Arthur Heymans arthur@aheymans.xyz
Gerrit-Comment-Date: Thu, 22 Jun 2023 21:33:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment