Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46319 )
Change subject: Makefile.inc: Omit unsupported warnings with non-GCC compilers
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/46319/2//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/46319/2//COMMIT_MSG@11
PS2, Line 11: Do not enable them for non-GCC compilers for now. Note that this patch
Was this confirmed with an up-to-date Clang? I remember discussions
around the fall-through thing and thought it turned out that it changed
already upstream.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46319
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4df3f89af6dac8ae65fb104a21547d5ac358221b
Gerrit-Change-Number: 46319
Gerrit-PatchSet: 2
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 13 Oct 2020 17:31:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment