Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35639 )
Change subject: fmap: Add get_fmap_flash_offset() ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/35639/1/src/include/fmap.h File src/include/fmap.h:
https://review.coreboot.org/c/coreboot/+/35639/1/src/include/fmap.h@23 PS1, Line 23: int find_fmap_directory(struct region_device *fmrd);
should be unexported, now that there are no more external users.
Ah good point. I missed that this was the only user of find_fmap_directory() outside of fmap.c
https://review.coreboot.org/c/coreboot/+/35639/1/src/include/fmap.h@53 PS1, Line 53: uint64_t get_fmap_flash_offset(void);
can you use fmap_locate_area_as_rdev("FMAP", ... […]
I thought of doing that initially, but skipped it looking at all the steps it would take to parse through the map to get to the same offset which was used in the first place to get to it. But, if it seems cleaner, I can push a patch to do that.