Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39115 )
Change subject: mb/google/dedede: Add WLAN configuration ......................................................................
Patch Set 3:
(6 comments)
https://review.coreboot.org/c/coreboot/+/39115/2/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/baseboard/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/39115/2/src/mainboard/google/dedede... PS2, Line 76: register "PcieRpEnable[3]" = "1"
sorry *register "PcieRpEnable[7]" = "1"
Done
https://review.coreboot.org/c/coreboot/+/39115/2/src/mainboard/google/dedede... PS2, Line 76: register "PcieRpEnable[3]" = "1" : register "PcieClkSrcUsage[3]" = "3" : register "PcieClkSrcClkReq[3]" = "3"
Will have to set PcieRpEnable[x] =0 for Pcie port not used and clock src usage to 0xff not used. […]
Done
https://review.coreboot.org/c/coreboot/+/39115/2/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/baseboard/gpio.c:
https://review.coreboot.org/c/coreboot/+/39115/2/src/mainboard/google/dedede... PS2, Line 15: gpio_table
Cnvi would need below GPIO also: […]
Done
https://review.coreboot.org/c/coreboot/+/39115/2/src/mainboard/google/dedede... PS2, Line 330: PAD_NC(GPP_H19, NONE),
BT disable needs to driven high as well
Done
https://review.coreboot.org/c/coreboot/+/39115/2/src/mainboard/google/dedede... PS2, Line 384: AP_SLP_WLAN_L
Should this be configured in this commit too?
Done
https://review.coreboot.org/c/coreboot/+/39115/2/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/waddledoo/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/39115/2/src/mainboard/google/dedede... PS2, Line 3: 3
1c. […]
Done