Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48526 )
Change subject: util: Modify LPDDR4 spd_tools to generate SPDs for ADL boards ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/48526/1/util/spd_tools/lp4x/gen_spd... File util/spd_tools/lp4x/gen_spd.go:
https://review.coreboot.org/c/coreboot/+/48526/1/util/spd_tools/lp4x/gen_spd... PS1, Line 38: PlatformADL Rather than adding another enum with same value as TGL, what do you think about reusing PlatformTGL here and adding a comment saying that ADL MRC has the exact same expectations as TGL MRC.
Another option is to update PlatformTGL to PlatformTGLADL to represent both platforms using a single enum.