[coreboot-gerrit] Change in coreboot[master]: soc/intel/jasperlake: Add Jasper Lake SoC support

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39823 )

Change subject: soc/intel/jasperlake: Add Jasper Lake SoC support
......................................................................

Patch Set 2: Code-Review+2

(1 comment)

https://review.coreboot.org/c/coreboot/+/39823/2/src/soc/intel/jasperlake/ac... 
File src/soc/intel/jasperlake/acpi/pci_irqs.asl:

https://review.coreboot.org/c/coreboot/+/39823/2/src/soc/intel/jasperlake/ac... 
PS2, Line 16: SOC_INTEL_TIGERLAKE_COPY
Was this required? I believe keeping SOC_INTEL_TIGERLAKE here would have been just fine? No board should be including the asl file from jasperlake yet.

I am guessing you did a find/replace for all occurrences of SOC_INTEL_TIGERLAKE and other Kconfigs. Humm.. That should work okay.