Attention is currently required from: Lance Zhao, Furquan Shaikh, Justin TerAvest, Tim Wawrzynczak, Todd Broch, Aaron Durbin, Patrick Rudolph, Karthik Ramasubramanian.
Sumeet R Pawnikar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50127 )
Change subject: drivers/intel/dptf: Add OEM variables support
......................................................................
Patch Set 13:
(3 comments)
Patchset:
PS6:
Please quote the BWG doc# in commit or comments for reference purpose, thanks.
Done.
File src/drivers/intel/dptf/dptf.c:
https://review.coreboot.org/c/coreboot/+/50127/comment/97463299_1a042432
PS8, Line 126: dptf_device_hid
Just double checking this device should use the same _HID as the DPTF device? I don't think I saw an […]
It's part of DPTF.
File src/drivers/intel/dptf/dptf.c:
https://review.coreboot.org/c/coreboot/+/50127/comment/64769322_60f6630c
PS12, Line 125: acpigen_write_STA(get_STA_value(config, DPTF_IETM));
Yes, I'll upload SSDT on bug.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/50127
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iaf3cf7b40e9a441b41d0c659d76895a58669c2fb
Gerrit-Change-Number: 50127
Gerrit-PatchSet: 13
Gerrit-Owner: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Justin TerAvest
teravest@chromium.org
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Lance Zhao
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Todd Broch
tbroch@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Lance Zhao
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Justin TerAvest
teravest@chromium.org
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Todd Broch
tbroch@chromium.org
Gerrit-Attention: Aaron Durbin
adurbin@chromium.org
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Thu, 27 May 2021 18:19:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Lance Zhao
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Comment-In-Reply-To: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-MessageType: comment