build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30012 )
Change subject: [WIP]sb/intel/common/smihandler: Hook up smmstore
......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/#/c/30012/1/src/southbridge/intel/common/smihand...
File src/southbridge/intel/common/smihandler.c:
https://review.coreboot.org/#/c/30012/1/src/southbridge/intel/common/smihand...
PS1, Line 287: io_smi->rax = ret;
code indent should use tabs where possible
https://review.coreboot.org/#/c/30012/1/src/southbridge/intel/common/smihand...
PS1, Line 287: io_smi->rax = ret;
please, no spaces at the start of a line
--
To view, visit
https://review.coreboot.org/c/coreboot/+/30012
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I20b87f3dcb898656ad31478820dd5153e4053cb2
Gerrit-Change-Number: 30012
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-CC: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 03 Dec 2018 01:25:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment