[coreboot-gerrit] Change in ...coreboot[master]: Makefile: Use -Wold-style-definition

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33678 )

Change subject: Makefile: Use -Wold-style-definition
......................................................................

Patch Set 1:
> Patch Set 1:
>
> Did you look at fixing the problems in src/cpu/x86/smm/smm_module_handler.c?
>
> We've got 2 definitions there that are probably pulled into every x86 platform.
> void __weak northbridge_smi_handler() {}
> void __weak southbridge_smi_handler() {}
>
> I looked at a couple of platforms, and those were the only 2 issues I saw, despite the overwhelming number of failures.

I don't think so: grep -r " __weak"