Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39285 )
Change subject: mb/google/dedede Add Audio support for waddledoo ......................................................................
Patch Set 18:
(4 comments)
https://review.coreboot.org/c/coreboot/+/39285/17/src/mainboard/google/deded... File src/mainboard/google/dedede/Kconfig:
https://review.coreboot.org/c/coreboot/+/39285/17/src/mainboard/google/deded... PS17, Line 19:
Nit: Please put this line back.
Done
https://review.coreboot.org/c/coreboot/+/39285/17/src/mainboard/google/deded... PS17, Line 3: DRIVERS_GENERIC_MAX98357A
Given that only some variants use this codec and headphone jack, can you please select under the con […]
Done
https://review.coreboot.org/c/coreboot/+/39285/17/src/mainboard/google/deded... File src/mainboard/google/dedede/variants/baseboard/gpio.c:
https://review.coreboot.org/c/coreboot/+/39285/17/src/mainboard/google/deded... PS17, Line 16:
Nit: Remove this extra line.
Done
https://review.coreboot.org/c/coreboot/+/39285/17/src/mainboard/google/deded... File src/mainboard/google/dedede/variants/waddledoo/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/39285/17/src/mainboard/google/deded... PS17, Line 83: 1f.3
Can you please confirm if this is correct? EDS marks it as reserved.
yes, I see the device getting listed in lspci