Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32349 )
Change subject: mb/google/octopus/variants/bloog: Disable unused I2C1
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/32349/2/src/mainboard/google/octopus/variant...
File src/mainboard/google/octopus/variants/bloog/overridetree.cb:
https://review.coreboot.org/#/c/32349/2/src/mainboard/google/octopus/variant...
PS2, Line 62: device pci 16.1 off end # - I2C 1
I don't see I2C 1 being used in any of the octopus variants. Probably it is a better idea to disable it in the baseboard devicetree itself.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32349
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7ed5065cfd0b9780d13feb27cc78b8090d7a03a6
Gerrit-Change-Number: 32349
Gerrit-PatchSet: 2
Gerrit-Owner: Tony Huang
tony-huang@quanta.corp-partner.google.com
Gerrit-Reviewer: Justin TerAvest
teravest@chromium.org
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Tony Huang
tony-huang@quanta.corp-partner.google.com
Gerrit-Reviewer: Wisley Chen
wisley.chen@quanta.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-Comment-Date: Thu, 18 Apr 2019 16:02:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment