Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45972 )
Change subject: soc/intel/alderlake/acpi: Add SoC ACPI directory for ADL ......................................................................
Patch Set 3:
(1 comment)
Patch Set 3: Code-Review+2
(3 comments)
I would prefer if ACPI would be reused instead of copied, but without any mainboard to test ADL with, it's a bit of a mess... I would like to get an ADL board in the tree as soon as possible.
yes, probably you will see mainboard code from tomorrow morning, working on it now to split into smaller block for easy review rather dump full mainboard code
I'm fine with this going in as-is now, but please ensure common ACPI is ready before adding support for another SoC. I'll be happy to review any common code changes.
yes, that should be idea. having another round of common code and land the next SoC
https://review.coreboot.org/c/coreboot/+/45972/3/src/soc/intel/alderlake/acp... File src/soc/intel/alderlake/acpi/tcss.asl:
PS3:
I expect that TCSS ACPI could be shared between TGL and ADL at some point. […]
Yes Angel, this code need to be further clear and submit as part of common code.