Rishabh Sharma has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33425 )
Change subject: qcs405: Add support for specifying mbn_version
......................................................................
Patch Set 7:
(2 comments)
https://review.coreboot.org/c/coreboot/+/33425/5/util/qualcomm/createxbl.py
File util/qualcomm/createxbl.py:
https://review.coreboot.org/c/coreboot/+/33425/5/util/qualcomm/createxbl.py@...
PS5, Line 125: '5' or '6'"
or '3'
Done
https://review.coreboot.org/c/coreboot/+/33425/5/util/qualcomm/createxbl.py@...
PS5, Line 217: is_ext_mbn_v5 = True
Again, you can remove this variable now. (You said "Done" but it's still here. […]
This variable is used at many places. I can't see any value add by deleting this variable.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33425
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic6e269e0f290692871875000586410217c25fc08
Gerrit-Change-Number: 33425
Gerrit-PatchSet: 7
Gerrit-Owner: Nitheesh Sekar
nsekar@codeaurora.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nitheesh Sekar
nsekar@codeaurora.org
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Rishabh Sharma
rishabh435@gmail.com
Gerrit-Comment-Date: Mon, 29 Jul 2019 05:22:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment