[coreboot-gerrit] Change in ...coreboot[master]: src/device/pci: Add support for discrete VGA initialization and OpROM...

[Arthur Heymans (Code Review)]

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31448 )

Change subject: src/device/pci: Add support for discrete VGA initialization and OpROM loading
......................................................................

Patch Set 14:

(1 comment)

https://review.coreboot.org/#/c/31448/14/src/device/pci_rom.c 
File src/device/pci_rom.c:

https://review.coreboot.org/#/c/31448/14/src/device/pci_rom.c@276 
PS14, Line 276: 	if (CONFIG(MULTIPLE_VGA_ADAPTERS))
              : 			return current;
              : 		/* Write ACPI VFCT only for Discrete VGA. */
              : 		/* TODO: do this also for Integrated VGA. */
              : 		break;
              : 	case PCI_CLASS_DISPLAY_OTHER:
              : 		if (!CONFIG(MULTIPLE_VGA_ADAPTERS))
              : 			return current;
              : 		break;
So if I understood it correctly only one entry of the VFCT gets used by the radeon driver and this is a hack to make sure the option rom you want gets loaded in VFCT, while the other option rom is at the legacy 0xc0000 location? I'd pursue what is attempted in https://review.coreboot.org/c/coreboot/+/31502 , it seems more promising.