Attention is currently required from: Nico Huber, Furquan Shaikh, Tim Wawrzynczak, Paul Menzel, Zhuohao Lee, Patrick Rudolph. Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57069 )
Change subject: coreboot tables: Add type-c port info to coreboot table ......................................................................
Patch Set 9:
(5 comments)
File payloads/libpayload/libc/coreboot.c:
https://review.coreboot.org/c/coreboot/+/57069/comment/17189068_e7d84543 PS8, Line 255: type_c_entry->port_count
something like `MIN(ARRAY_SIZE(info->type_c_config_info), type_c_entry->port_count)`?
Done
File src/drivers/intel/pmc_mux/conn/conn.c:
PS8:
looks like stale changes
Ack
File src/mainboard/google/volteer/mainboard.c:
https://review.coreboot.org/c/coreboot/+/57069/comment/73906a02_ddbc84d6 PS8, Line 79: pmc = pcidev_path_on_root(PCH_DEVFN_PMC); : if (!pmc || !pmc->link_list->children) { : printk(BIOS_ERR, "%s: unable to find PMC device or its mux\n", __func__); : return 0; : } : : /* : * Add each port underneath PMC.MUX; some variants may not have this defined, : * so it's okay to just silently return here. : */ : mux = pmc->link_list->children; : : while ((child = dev_bus_each_child(mux->link_list, child)) != NULL) { : if (count >= max_ports) : break;
We're now using this logic in several places, maybe there should be a helper function in pmc_mux to […]
Sure, I'll change this to add that.
https://review.coreboot.org/c/coreboot/+/57069/comment/d1312b76_718a2d18 PS8, Line 95: if (fw_config_probe(FW_CONFIG(DB_USB, USB4_GEN2)) : || fw_config_probe(FW_CONFIG(DB_USB, USB3_ACTIVE)) : || fw_config_probe(FW_CONFIG(DB_USB, USB4_GEN3)) : || fw_config_probe(FW_CONFIG(DB_USB, USB3_NO_A)))
I'd also move this out to the beginning of the function, so if this fails, then the function returns […]
Done
https://review.coreboot.org/c/coreboot/+/57069/comment/7d00602a_29f1a5c1 PS8, Line 109: return count;
nit: empty line after `}`
Done