Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34337 )
Change subject: soc/intel/common: add advanced macros for gpio config ......................................................................
Patch Set 2:
(5 comments)
https://review.coreboot.org/c/coreboot/+/34337/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/34337/2//COMMIT_MSG@19 PS2, Line 19: trig What is trig set to for a) GPO and b) NF.
I am wondering if it is always just set to disable?
https://review.coreboot.org/c/coreboot/+/34337/2/src/soc/intel/common/block/... File src/soc/intel/common/block/gpio/Kconfig:
https://review.coreboot.org/c/coreboot/+/34337/2/src/soc/intel/common/block/... PS2, Line 49: SOC_INTEL_COMMON_BLOCK_GPIO_ADVANCED_MACROS Why do we need a special Kconfig to guard the macro definitions? If a board doesn't use it, there would be no harm.
https://review.coreboot.org/c/coreboot/+/34337/2/src/soc/intel/common/block/... File src/soc/intel/common/block/include/intelblocks/gpio_defs.h:
https://review.coreboot.org/c/coreboot/+/34337/2/src/soc/intel/common/block/... PS2, Line 421: trig Is the trig always set to disable for NF by inteltool?
https://review.coreboot.org/c/coreboot/+/34337/2/src/soc/intel/common/block/... PS2, Line 427: pull Why is pull required on pad which is configured as GPO and being actively driven?
https://review.coreboot.org/c/coreboot/+/34337/2/src/soc/intel/common/block/... PS2, Line 427: trig The trigger matters only for the internal Rx pad state. Is this required to be configured by mainboard? Or can this be just set to DISABLE always?