23 Sep
2020
23 Sep
'20
8:31 p.m.
Amanda Hwang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45647 )
Change subject: util: Add new memory part for zork boards ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45647/1/util/spd_tools/ddr4/global_... File util/spd_tools/ddr4/global_ddr4_mem_parts.json.txt:
https://review.coreboot.org/c/coreboot/+/45647/1/util/spd_tools/ddr4/global_... PS1, Line 189: "capacityPerDieGb": 16,
The capacity per die should be 8Gb. It's a 2 die package, so 8Gb x 2 die = 16Gb. […]
Done. Thanks for your review.
--
To view, visit https://review.coreboot.org/c/coreboot/+/45647
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifdcc7536441e9f0b94543c6f06fe466596f752dc
Gerrit-Change-Number: 45647
Gerrit-PatchSet: 2
Gerrit-Owner: Amanda Hwang amanda_hwang@compal.corp-partner.google.com
Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Nick Vaccaro nvaccaro@google.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: Rob Barnes robbarnes@google.com
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 24 Sep 2020 02:31:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Rob Barnes robbarnes@google.com
Gerrit-MessageType: comment