1 Oct
2019
1 Oct
'19
8:16 p.m.
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35643 )
Change subject: util/intelp2m: add Intel Pad to Macro util ......................................................................
Patch Set 11:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35643/11/util/intelp2m/sunrise/macr... File util/intelp2m/sunrise/macro.go:
https://review.coreboot.org/c/coreboot/+/35643/11/util/intelp2m/sunrise/macr... PS11, Line 307: case rxDisable | txDisable: Uhm... does this mean if rxDisable and/or txDisable is set, the pad is NC? Did you mean rxDisable && txDisable?
--
To view, visit https://review.coreboot.org/c/coreboot/+/35643
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If3e3b523c4f63dc2f91e9ccd16934e3a1b6e21fa
Gerrit-Change-Number: 35643
Gerrit-PatchSet: 11
Gerrit-Owner: Maxim Polyakov max.senia.poliak@gmail.com
Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Maxim Polyakov max.senia.poliak@gmail.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Christian Walter christian.walter@9elements.com
Gerrit-CC: Maxim Polyakov m.poliakov@yahoo.com
Gerrit-CC: Michael Niewöhner
Gerrit-CC: Nico Huber nico.h@gmx.de
Gerrit-Comment-Date: Tue, 01 Oct 2019 18:16:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment