build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30939 )
Change subject: nb/intel/pineview: Move to C_ENVIRONMENT_BOOTBLOCK ......................................................................
Patch Set 3:
(3 comments)
https://review.coreboot.org/#/c/30939/3/src/mainboard/foxconn/d41s/early_ini... File src/mainboard/foxconn/d41s/early_init.c:
https://review.coreboot.org/#/c/30939/3/src/mainboard/foxconn/d41s/early_ini... PS3, Line 33: pci_read_config16(PCI_DEV(0, 0x1f, 0), LPC_IO_DEC) | 0x0010); line over 80 characters
https://review.coreboot.org/#/c/30939/3/src/mainboard/intel/d510mo/early_ini... File src/mainboard/intel/d510mo/early_init.c:
https://review.coreboot.org/#/c/30939/3/src/mainboard/intel/d510mo/early_ini... PS3, Line 34: pci_read_config16(PCI_DEV(0, 0x1f, 0), LPC_IO_DEC) | 0x0010); line over 80 characters
https://review.coreboot.org/#/c/30939/3/src/southbridge/intel/i82801gx/bootb... File src/southbridge/intel/i82801gx/bootblock_gcc.c:
https://review.coreboot.org/#/c/30939/3/src/southbridge/intel/i82801gx/bootb... PS3, Line 38: pci_write_config32(PCI_DEV(0, 0x1f, 0), RCBA, (uintptr_t)DEFAULT_RCBA | 1); line over 80 characters