Name of user not set #1002358 has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33234 )
Change subject: security/intel/stm: Add STM support
......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/Kconfig
File src/security/intel/stm/Kconfig:
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/Kconfig@7
PS1, Line 7: depends on (PLATFORM_USES_FSP2_0||PLATFORM_USES_FSP1_1||PLATFORM_USES_FSP1_0)
the FSP depends were suggested (on the original change that is split in this submission) by Philipp […]
Done
https://review.coreboot.org/#/c/33234/1/src/security/intel/stm/Kconfig@12
PS1, Line 12: hex "mseg size"
generally 1MB should suffice for a STM only application and 3MB+ depending upon the size of the VM/P […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33234
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If4adcd92c341162630ce1ec357ffcf8a135785ec
Gerrit-Change-Number: 33234
Gerrit-PatchSet: 3
Gerrit-Owner: Name of user not set #1002358
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Name of user not set #1002358
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-CC: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Comment-Date: Thu, 06 Jun 2019 20:40:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Rudolph
patrick.rudolph@9elements.com
Comment-In-Reply-To: Name of user not set #1002358
Gerrit-MessageType: comment