Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32297 )
Change subject: soc/intel/cannonlake: Enable PlatformDebugConsent by Kconfig
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/32297/2/src/soc/intel/cannonlake/romstage/fs...
File src/soc/intel/cannonlake/romstage/fsp_params.c:
https://review.coreboot.org/#/c/32297/2/src/soc/intel/cannonlake/romstage/fs...
PS2, Line 119: m_cfg->PlatformDebugConsent = config->DebugConsent;
Please no competing options in Kconfig and `chip.h`. I guess you can […]
If we need to get rid of the devicetree option, USE_DBC_CANNONLAKE will have to instead be a choice in Kconfig.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32297
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib845b5e42bc78fb352a0c97c6301f2aeca522f29
Gerrit-Change-Number: 32297
Gerrit-PatchSet: 2
Gerrit-Owner: Kane Chen
kane.chen@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Kane Chen
kane.chen@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-Comment-Date: Fri, 12 Apr 2019 17:01:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment