Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37948 )
Change subject: mb/google/puff: [WIP] Add power sequencing for LSPCON ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/37948/1/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/puff/gpio.c:
https://review.coreboot.org/c/coreboot/+/37948/1/src/mainboard/google/hatch/... PS1, Line 108: /* C14 : BT_DISABLE_L */ Can you sort these, so:
``` /* C10 : .. */ .. /* C11 : .. */ .. /* C14 : BT_DISABLE_L */ PAD_CFG_GPO(GPP_C14, 0, DEEP), ```
https://review.coreboot.org/c/coreboot/+/37948/1/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/puff/ramstage.c:
https://review.coreboot.org/c/coreboot/+/37948/1/src/mainboard/google/hatch/... PS1, Line 24: * Enable power to FPMCU, wait for power rail to stabilize, : * and then deassert FPMCU reset. : * Waiting for the power rail to stabilize can take a while, : * a minimum of 400us on Kohaku. I guess this doesn't make sense however I see what you are trying to do with lspcon.