Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30903 )
Change subject: qclib: Differentiate between ES_1.0 and ES1.1 silicon ......................................................................
Patch Set 12: Code-Review+2
(2 comments)
https://review.coreboot.org/#/c/30903/12/src/soc/qualcomm/qcs405/qclib_execu... File src/soc/qualcomm/qcs405/qclib_execute.c:
https://review.coreboot.org/#/c/30903/12/src/soc/qualcomm/qcs405/qclib_execu... PS12, Line 32: 0x0194D000 nit: the rest of the file uses lower cases hex values
https://review.coreboot.org/#/c/30903/12/src/soc/qualcomm/qcs405/qclib_execu... PS12, Line 32: #define TCSR_SOC_HW_VERSION 0x0194D000 : #define ES_1_0 0x20140100 : #define ES_1_1 0x20140101 As long as we really only need them here, it's okay-ish to keep them here, but the SoC revision really has little to do with qclib_execute, does it?