Patch set 12:Code-Review +2

View Change

2 comments:

• File src/soc/qualcomm/qcs405/qclib_execute.c:

  • Patch Set #12, Line 32: 0x0194D000

    nit: the rest of the file uses lower cases hex values

  • Patch Set #12, Line 32:

    #define TCSR_SOC_HW_VERSION 0x0194D000
    #define ES_1_0 0x20140100
    #define ES_1_1 0x20140101
    

    As long as we really only need them here, it's okay-ish to keep them here, but the SoC revision really has little to do with qclib_execute, does it?

To view, visit change 30903. To unsubscribe, or for help writing mail filters, visit settings.