Tristan Corrick has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30967 )
Change subject: util/autoport: Correct DSDT header ......................................................................
Patch Set 4: Code-Review+1
(4 comments)
Looks good, just a few nits with the commit message.
https://review.coreboot.org/#/c/30967/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/30967/4//COMMIT_MSG@7 PS4, Line 7: header Do you mean "include statement"?
https://review.coreboot.org/#/c/30967/4//COMMIT_MSG@9 PS4, Line 9: change Please give the commit hash and summary.
https://review.coreboot.org/#/c/30967/4//COMMIT_MSG@9 PS4, Line 9: emoved Typo: "moved".
https://review.coreboot.org/#/c/30967/4//COMMIT_MSG@10 PS4, Line 10: Correct this so resulting autoport errors less. This sentence doesn't make sense. Perhaps say that it fixes build errors in the autoport output, or omit it altogether.