Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35619 )
Change subject: cpu/intel/common: Move intel_ht_sibling() to common folder ......................................................................
Patch Set 1:
(8 comments)
https://review.coreboot.org/c/coreboot/+/35619/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/35619/1//COMMIT_MSG@12 PS1, Line 12: HyperThreading Hyper-threading
https://en.wikipedia.org/wiki/Hyper-threading
https://review.coreboot.org/c/coreboot/+/35619/1//COMMIT_MSG@12 PS1, Line 12: raceconditions race conditions
https://en.wikipedia.org/wiki/Race_condition
https://review.coreboot.org/c/coreboot/+/35619/1/src/cpu/intel/common/common... File src/cpu/intel/common/common.h:
https://review.coreboot.org/c/coreboot/+/35619/1/src/cpu/intel/common/common... PS1, Line 31: hyperthreading Hyper-threading
https://review.coreboot.org/c/coreboot/+/35619/1/src/cpu/intel/common/common... PS1, Line 31: threat thread
https://review.coreboot.org/c/coreboot/+/35619/1/src/cpu/intel/common/hypert... File src/cpu/intel/common/hyperthreading.c:
https://review.coreboot.org/c/coreboot/+/35619/1/src/cpu/intel/common/hypert... PS1, Line 18: /* Return true if running thread does not have the smallest lapic ID Please use
/* * … */
https://review.coreboot.org/c/coreboot/+/35619/1/src/cpu/intel/common/hypert... PS1, Line 27: hyperthreading Hyper-threading
https://review.coreboot.org/c/coreboot/+/35619/1/src/cpu/intel/common/hypert... PS1, Line 29: 0 false
https://review.coreboot.org/c/coreboot/+/35619/1/src/cpu/intel/common/hypert... PS1, Line 44: - Please add spaces around the operator.