build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34188 )
Change subject: mb/google/octopus/variants/garg: support LTE power sequence. ......................................................................
Patch Set 3:
(4 comments)
https://review.coreboot.org/c/coreboot/+/34188/3/src/mainboard/google/octopu... File src/mainboard/google/octopus/smihandler.c:
https://review.coreboot.org/c/coreboot/+/34188/3/src/mainboard/google/octopu... PS3, Line 46: PAD_CFG_GPO(GPIO_117, 0, DEEP), /* PCIE_WAKE1_B -- FULL_CARD_POWER_OFF */ line over 96 characters
https://review.coreboot.org/c/coreboot/+/34188/3/src/mainboard/google/octopu... File src/mainboard/google/octopus/variants/baseboard/gpio.c:
https://review.coreboot.org/c/coreboot/+/34188/3/src/mainboard/google/octopu... PS3, Line 333: PAD_CFG_GPO_IOSSTATE_IOSTERM(GPIO_67, 0, DEEP, NONE, TxLASTRxE, DISPUPD), /* UART2-CTS_B -- EN_PP3300_DX_LTE_SOC */ line over 96 characters
https://review.coreboot.org/c/coreboot/+/34188/3/src/mainboard/google/octopu... PS3, Line 339: PAD_CFG_GPO_IOSSTATE_IOSTERM(GPIO_161, 1, DEEP, UP_20K, Tx1RxDCRx0, DISPUPD), /* AVS_I2S1_MCLK -- LTE_OFF_ODL */ line over 96 characters
https://review.coreboot.org/c/coreboot/+/34188/3/src/mainboard/google/octopu... File src/mainboard/google/octopus/variants/garg/gpio.c:
https://review.coreboot.org/c/coreboot/+/34188/3/src/mainboard/google/octopu... PS3, Line 22: #define DEFAULT_OVERRIDE_GPIOS() PAD_NC(GPIO_104, UP_20K), \ Macros with complex values should be enclosed in parentheses