Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/em100/+/46927 )
Change subject: Add install and uninstall targets to Makefile
......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/em100/+/46927/1/Makefile
File Makefile:
https://review.coreboot.org/c/em100/+/46927/1/Makefile@76
PS1, Line 76: plugdev
OpenSUSE doesn't have it either. Debian (and Ubuntu) does. […]
If somebody wants to make the install target more OS/distro independent, they can do so in a follow up. Let's not wait for perfection.
https://review.coreboot.org/c/em100/+/46927/1/Makefile@78
PS1, Line 78: uninstall: /usr/local/bin/em100
should this also work on $(PREFIX)? Does an "uninstall" target even make sense?
--
To view, visit
https://review.coreboot.org/c/em100/+/46927
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: em100
Gerrit-Branch: master
Gerrit-Change-Id: Ibfcd6f9f2f577b1f7d8d2d4b0a89405d38264d3d
Gerrit-Change-Number: 46927
Gerrit-PatchSet: 2
Gerrit-Owner: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Wed, 04 Nov 2020 21:59:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Georgi
pgeorgi@google.com
Comment-In-Reply-To: Stefan Reinauer
stefan.reinauer@coreboot.org
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment
