Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30020 )
Change subject: cpu/x86/lapic: Link apic_timer.c into SMM
......................................................................
Patch Set 2:
/cb-build/coreboot-gerrit.0/HP_PAVILION_M6_1035DX/smm/cpu/x86/lapic/apic_timer.o: In function `udelay':
/home/coreboot/slave-root/workspace/coreboot-gerrit/src/cpu/x86/lapic/apic_timer.c:118: multiple definition of `udelay'
/cb-build/coreboot-gerrit.0/HP_PAVILION_M6_1035DX/smm/cpu/amd/agesa/family15tn/udelay.o:/home/coreboot/slave-root/workspace/coreboot-gerrit/src/cpu/amd/agesa/family15tn/udelay.c:30: first defined here
--
To view, visit
https://review.coreboot.org/c/coreboot/+/30020
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic14919f89b226b4d5185e49ae857e7dd61bbccce
Gerrit-Change-Number: 30020
Gerrit-PatchSet: 2
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 03 Dec 2018 13:35:22 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment