Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33435 )
Change subject: mb/intel/whl_rvp: Configure FSP UPDs of DDI ports for whlrvp ......................................................................
Patch Set 1:
(4 comments)
https://review.coreboot.org/#/c/33435/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/33435/1//COMMIT_MSG@12 PS1, Line 12: remove whitespace?
https://review.coreboot.org/#/c/33435/1//COMMIT_MSG@13 PS1, Line 13: same
https://review.coreboot.org/#/c/33435/1/src/mainboard/intel/coffeelake_rvp/v... File src/mainboard/intel/coffeelake_rvp/variants/whl_u/devicetree.cb:
https://review.coreboot.org/#/c/33435/1/src/mainboard/intel/coffeelake_rvp/v... PS1, Line 14: B/C comment only says DDI ports over B and C is enable bt below code sets it for D and F as well?
https://review.coreboot.org/#/c/33435/1/src/mainboard/intel/coffeelake_rvp/v... PS1, Line 19: B/C same?