Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42490 )
Change subject: ACPI: Final APM_CNT_GNVS_UPATE cleanup
......................................................................
Patch Set 1:
Patch Set 1: Code-Review+1
(1 comment)
What should be done for testing? Just boot test one real platform? Or is QEMU enough?
There are TODOs still in the dependencies. Need to test with HAVE_SMI_HANDLER=y and DEBUG_SMI=y and verify GNVS pointer is correct for SMM.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42490
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I31b5652a946b0d9bd1909ff8bde53b43e06e2cd9
Gerrit-Change-Number: 42490
Gerrit-PatchSet: 1
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Sat, 20 Jun 2020 20:38:54 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment