Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34518 )
Change subject: src/device/oprom src/lib: Remove broken bootsplash display code
......................................................................
Patch Set 4:
Patch Set 1:
Yep. Added the rest. Forgot to add it to the commit.
I disagree with touching src/device/Kconfig as it does not only affect coreboot, but also SeaBIOS. I think, it should be moved in a different commit
I did not see where SeaBIOS would inherit CONFIG_BOOTSPLASH from coreboot .config..
Anyways.. remove:
src/lib/Makefile.inc:ramstage-$(CONFIG_BOOTSPLASH) += jpeg.c
Most of the time, I prefer changes to util/ as separate commits.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34518
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I77619e1a885ed87123f4f5f185969d16d557e490
Gerrit-Change-Number: 34518
Gerrit-PatchSet: 4
Gerrit-Owner: Mimoja
coreboot@mimoja.de
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Mimoja
coreboot@mimoja.de
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 23 Jul 2019 16:24:19 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment